Skip to content

Conversation

chenhao0205
Copy link
Contributor

@chenhao0205 chenhao0205 commented Sep 26, 2025

📌 PR 内容 / PR Description

  • This PR introduces the functionality of enabling default parameters injection in the Milvus component.
    Default Params Injection:
    Added a feature to inject default index parameters into the Milvus database. This simplifies the configuration process and ensures that the database is initialized with optimal settings by default.
    Index Type Correction:
    Implemented a mechanism to correct invalid index_type inputs when connected milvus does not support, while other incompatibilities lead to error raise. This prevents errors during database operations and ensures that the index is created with valid parameters.

✅ 变更类型 / Type of Change

  • [√] 性能优化 / Performance optimization

📷 截图 / Demo

  • Conducted comprehensive local testing of the newly added default parameters injection functionality. This included testing normal parameter injection, handling parameter conflicts, and dealing with exceptional situations. The test results indicate that the functionality is working as expected, with no significant issues detected.
image

Copy link
Contributor

@ChenJiahaoST ChenJiahaoST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个pr的改动略大,只需确保能够给对应的index_type正确的参数默认值即可,不需要修改其他已验证过的逻辑,改动尽量小一些

@mergify mergify bot added the lint_pass label Oct 14, 2025
@ChenJiahaoST
Copy link
Contributor

建议milvus store添加一个能够错误index的相关测例

@lwj-st lwj-st removed the lint_pass label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants