-
Notifications
You must be signed in to change notification settings - Fork 269
[Optimization] Enable Default Params Injection in Milvus Database #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chenhao0205
wants to merge
8
commits into
LazyAGI:main
Choose a base branch
from
chenhao0205:ch/opt-milvus
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenJiahaoST
requested changes
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个pr的改动略大,只需确保能够给对应的index_type正确的参数默认值即可,不需要修改其他已验证过的逻辑,改动尽量小一些
ChenJiahaoST
requested changes
Oct 11, 2025
ChenJiahaoST
approved these changes
Oct 14, 2025
建议milvus store添加一个能够错误index的相关测例 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 内容 / PR Description
Default Params Injection:
Added a feature to inject default index parameters into the Milvus database. This simplifies the configuration process and ensures that the database is initialized with optimal settings by default.
Index Type Correction:
Implemented a mechanism to correct invalid index_type inputs when connected milvus does not support, while other incompatibilities lead to error raise. This prevents errors during database operations and ensures that the index is created with valid parameters.
✅ 变更类型 / Type of Change
📷 截图 / Demo